Rename parameter in rbs_intern_type_name for clarity#3023
Merged
Conversation
The C99_compile CI job builds the extension with `-Werror
-Wc2x-extensions`, which promotes the `-Wc++-keyword` diagnostic
(enabled via `-Wc++-compat`) to an error. The `namespace` parameter of
`rbs_intern_type_name` collides with a C++ keyword, so the build failed
with:
error: identifier 'namespace' conflicts with a C++ keyword [-Werror,-Wc++-keyword]
Rename the parameter to `type_namespace` to keep the source C++-compatible.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013PkLsC6iM8VJgTB3aCrcXh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved code clarity by renaming a parameter in the
rbs_intern_type_namefunction to better reflect its purpose.Key Changes
namespaceparameter totype_namespacein therbs_intern_type_namefunctionImplementation Details
This change makes the parameter name more explicit and descriptive, distinguishing it from other namespace-related parameters in the codebase. The rename clarifies that this namespace specifically relates to type names, improving code readability and reducing potential confusion when working with multiple namespace types.
https://claude.ai/code/session_013PkLsC6iM8VJgTB3aCrcXh